Support clang-format whose version is not 7.0 #5139
Conversation
jiangzihao2009
changed the title
jiangzihao2009
changed the title
ci/travis/format.sh
Outdated
| echo "Please install clang-format 7.0.0. You currently are using $CLANG_FORMAT_VERSION." | ||
| exit 1 | ||
| echo "WARNING: Please install clang-format 7.0.0. You currently are using $CLANG_FORMAT_VERSION." | ||
| read -p "Are you sure to continue?[y/n]" input |
There was a problem hiding this comment.
Maybe rephrase like this?
WARNING: Ray uses clang-format 7.0.0, but you are using $CLANG_FORMAT_VERSION. This might generate different results. Do you want to continue? [y/n]
There was a problem hiding this comment.
And we should do the same thing for other tools as well.
|
Test PASSed. |
ci/travis/format.sh
Outdated
| fi | ||
| else | ||
| echo "WARNING: clang-format is not installed!" | ||
| echo "WARNING: clang-format is not installed!" | ||
| exit 1 |
There was a problem hiding this comment.
I didn't exit here before because I thought some Python developers (e.g., for RLlib) might not install clang-format. It might be better to warn them and then ask if they want to proceed?
|
Test PASSed. |
|
Test PASSed. |
What do these changes do?
Print a warning and ask user whether to continue when installed version of clang-format is not 7.0.
Related issue number
Linter
scripts/format.shto lint the changes in this PR.