Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove ray._raylet.check_health #47526

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[Core] Remove ray._raylet.check_health #47526

merged 4 commits into from
Sep 9, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Sep 6, 2024 •
edited
Loading

Why are these changes needed?

Remove yet another case where the communication to gcs is not through GcsClient. check_health can be replaced with kv getting cluster metadata and comparing ray version.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Remove ray._raylet.check_health
f6272e9 
Signed-off-by: Jiajun Yao <[email protected]>
@jjyao
more
a8d0c39 
Signed-off-by: Jiajun Yao <[email protected]>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Sep 6, 2024
@jjyao jjyao marked this pull request as ready for review September 9, 2024 05:50
@jjyao jjyao requested a review from a team as a code owner September 9, 2024 05:50
@jjyao jjyao merged commit 1dd8d60 into ray-project:master Sep 9, 2024
5 checks passed
@jjyao jjyao deleted the jjyao/healll branch September 9, 2024 11:55
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 12, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
3f9aafb 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
d833209 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
88f2013 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
455d7d3 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
bbe680a 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
b8a685e 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
f33d4d5 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
c350ed2 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
053e9cd 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
89927b9 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
fc38662 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
23c848d 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
cfb061e 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Remove ray._raylet.check_health (ray-project#47526)
bb015e4 
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynewang rynewang rynewang approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @rynewang