Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] remove outdated microbenchmark release test #47502

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[serve] remove outdated microbenchmark release test #47502

merged 1 commit into from
Sep 5, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Sep 5, 2024 •
edited
Loading

Why are these changes needed?

Remove serve_serve_micro_benchmark release test, which is outdated and replaced by serve_microbenchmarks.

Related issue number

closes #47496

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

GeneDer
GeneDer approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zcin zcin added the go add ONLY when ready to merge, run all tests label Sep 5, 2024
@zcin zcin merged commit ca85922 into ray-project:master Sep 5, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 12, 2024
@zcin @ujjawal-khare
[serve] remove outdated microbenchmark release test (ray-project#47502)
533e168 
Remove `serve_serve_micro_benchmark` release test, which is outdated and
replaced by `serve_microbenchmarks`.

## Related issue number

closes ray-project#47496

Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] remove outdated microbenchmark release test (ray-project#47502)
da96dea 
Remove `serve_serve_micro_benchmark` release test, which is outdated and
replaced by `serve_microbenchmarks`.

## Related issue number

closes ray-project#47496

Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@zcin @ujjawal-khare
[serve] remove outdated microbenchmark release test (ray-project#47502)
61e0d71 
Remove `serve_serve_micro_benchmark` release test, which is outdated and
replaced by `serve_microbenchmarks`.

## Related issue number

closes ray-project#47496

Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

@edoakes edoakes Awaiting requested review from edoakes

@can-anyscale can-anyscale Awaiting requested review from can-anyscale

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release test serve_serve_micro_benchmark.aws failed
2 participants
@zcin @GeneDer