Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken asyncio tests for aiohttp 3.10.0 #46988

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix broken asyncio tests for aiohttp 3.10.0 #46988

merged 3 commits into from
Aug 7, 2024

Conversation

alanwguo
Copy link
Contributor

@alanwguo alanwguo commented Aug 6, 2024 •
edited
Loading

Why are these changes needed?

Need to fix these tests for macosx.

Related issue number

Follow-up for #46904
Fixes #46890
Fixes #45356

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alanwguo alanwguo added the go add ONLY when ready to merge, run all tests label Aug 6, 2024
@alanwguo
update requirements
2e11da7 
Signed-off-by: Alan Guo <[email protected]>
@alanwguo
fixup
61474ff 
Signed-off-by: Alan Guo <[email protected]>
can-anyscale
can-anyscale approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@can-anyscale can-anyscale enabled auto-merge (squash) August 7, 2024 15:16
@can-anyscale can-anyscale merged commit bf32fa4 into ray-project:master Aug 7, 2024
5 of 6 checks passed
dev-goyal pushed a commit to dev-goyal/ray that referenced this pull request Aug 8, 2024
@alanwguo @dev-goyal
fix broken asyncio tests for aiohttp 3.10.0 (ray-project#46988)
6b95f77 
Need to fix these tests for macosx.

## Related issue number
Follow-up for ray-project#46904
Fixes ray-project#46890
Fixes ray-project#45356

---------

Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Dev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-anyscale can-anyscale can-anyscale approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
2 participants
@alanwguo @can-anyscale