Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Add a parameter to allow overriding LanceDB scanner options #46975

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[data] Add a parameter to allow overriding LanceDB scanner options #46975

merged 2 commits into from
Aug 6, 2024

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Aug 6, 2024

Why are these changes needed?

The default batch_size for the LanceDatasource is too big for some use cases. This PR adds a new scanner_options argument to allow overriding the LanceDB scanner options.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen
add scanner_options
6a5ec2d 
Signed-off-by: Hao Chen <[email protected]>
@raulchen
test
d9120cc 
Signed-off-by: Hao Chen <[email protected]>
bveeramani
bveeramani approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@raulchen raulchen enabled auto-merge (squash) August 6, 2024 00:19
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 6, 2024
@raulchen raulchen merged commit d169386 into ray-project:master Aug 6, 2024
6 checks passed
rynewang pushed a commit to rynewang/ray that referenced this pull request Aug 6, 2024
@raulchen @rynewang
[data] Add a parameter to allow overriding LanceDB scanner options (r…
bb86490 
…ay-project#46975)

The default `batch_size` for the LanceDatasource is too big for some use
cases. This PR adds a new `scanner_options` argument to allow overriding
the LanceDB scanner options.

---------

Signed-off-by: Hao Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@bveeramani bveeramani bveeramani approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulchen @scottjlee @bveeramani