Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py312] ml gpu tests #46970

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[py312] ml gpu tests #46970

merged 3 commits into from
Aug 6, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Aug 5, 2024

Add python 3.12 gpu tests for ml

Test:

  • CI

@can-anyscale can-anyscale force-pushed the can-12ml-gpu branch 2 times, most recently from d3dd861 to d782b06 Compare August 5, 2024 18:35
Base automatically changed from can-12ml to can-ml12 August 5, 2024 21:44
@can-anyscale can-anyscale changed the base branch from can-ml12 to master August 5, 2024 21:56
@@ -53,7 +65,6 @@ steps:
depends_on: [ "mlbuild", "forge" ]

- label: ":train: ml: {{matrix.python}} tests ({{matrix.worker_id}})"
key: ml_python_tests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added for easier testing in the previous PR, but do not need this for production

@@ -69,7 +76,7 @@ def test_repr():
assert pattern.match(representation)


def create_checkpoint_preprocessor() -> Tuple[TensorflowCheckpoint, Preprocessor]:
def create_checkpoint_preprocessor() -> Tuple["TensorflowCheckpoint", Preprocessor]:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is required so that TensorflowCheckpoint as a type does not scream at runtime

Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@can-anyscale can-anyscale enabled auto-merge (squash) August 6, 2024 00:20
@can-anyscale can-anyscale merged commit 779ee56 into master Aug 6, 2024
6 checks passed
@can-anyscale can-anyscale deleted the can-12ml-gpu branch August 6, 2024 01:49
rynewang pushed a commit to rynewang/ray that referenced this pull request Aug 6, 2024
Add python 3.12 gpu tests for ml

Test:
- CI

---------

Signed-off-by: can <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-build go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants