Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add missing __init__.py to algorithms/dqn folder. #46898

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

MaxVanDijck
Copy link
Contributor

@MaxVanDijck MaxVanDijck commented Jul 31, 2024

Why are these changes needed?

Trying to run the code in:

from ray.rllib.algorithms.dqn.torch.dqn_rainbow_torch_rl_module import (

results in

ModuleNotFoundError: No module named 'ray.rllib.algorithms.dqn.torch'

Related issue number

#46773

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MaxVanDijck MaxVanDijck changed the title add __init__.py [RLlib] add __init__.py to dqn folder Jul 31, 2024
Signed-off-by: MaxVanDijck <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch! Thanks for the fix @MaxVanDijck!

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MaxVanDijck

@sven1977 sven1977 changed the title [RLlib] add __init__.py to dqn folder [RLlib] Add missing __init__.py to algorithms/dqn folder. Aug 8, 2024
@sven1977 sven1977 enabled auto-merge (squash) August 8, 2024 10:52
@sven1977
Copy link
Contributor

sven1977 commented Aug 8, 2024

auto-merge enabled ...

@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 8, 2024
@sven1977 sven1977 merged commit 4f4883f into ray-project:master Aug 8, 2024
6 of 7 checks passed
dev-goyal pushed a commit to dev-goyal/ray that referenced this pull request Aug 8, 2024
@MaxVanDijck MaxVanDijck deleted the init-file-for-dqn-torch branch August 8, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants