Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Move datasource implementations to _internal subpackage #46825

Merged
merged 12 commits into from
Aug 6, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jul 26, 2024

Why are these changes needed?

In accordance with the new API stability policy, we removed the DeveloperAPI annotation from Datasource implementations and moved the code to a new ray.data._internal.datasource subpackage.

This PR moves and cleans up some APIs that got missed.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@@ -122,3 +142,293 @@ def _resolve_full_path(self, relative_path):
return f"{protocol}:https://{relative_path}"

return relative_path


def _convert_example_to_dict(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't adding any new code.

Previously, TFRecordsDatasource was in ray._internal.datasource but the utility functions were in ray.datasource. I'm just moving the utility functions out of ray.datasource.

@bveeramani bveeramani marked this pull request as ready for review August 5, 2024 19:08
@bveeramani bveeramani enabled auto-merge (squash) August 5, 2024 20:50
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 5, 2024
Signed-off-by: Balaji Veeramani <[email protected]>
@github-actions github-actions bot disabled auto-merge August 5, 2024 23:22
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani merged commit 86d94d7 into ray-project:master Aug 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants