-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Improve filesystem retry coverage #46685
Merged
bveeramani
merged 10 commits into
ray-project:master
from
bveeramani:improve-retry-coverage
Jul 19, 2024
Merged
[Data] Improve filesystem retry coverage #46685
bveeramani
merged 10 commits into
ray-project:master
from
bveeramani:improve-retry-coverage
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
July 17, 2024 23:31
bveeramani
commented
Jul 17, 2024
python/ray/data/context.py
Outdated
Comment on lines
97
to
104
DEFAULT_RETRIED_FILESYSTEM_ERRORS = ( | ||
"AWS Error INTERNAL_FAILURE", | ||
"AWS Error NETWORK_CONNECTION", | ||
"AWS Error SLOW_DOWN", | ||
"AWS Error UNKNOWN (HTTP status 503)", | ||
"AWS Error ACCESS_DENIED", | ||
"AWS Error NETWORK_CONNECTION", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consolidating all of the transient errors in one place so users don't need to configure retries for opening files/reading files/writing files separately.
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
changed the title
[Data] Improve retry coverage
[Data] Improve filesystem retry coverage
Jul 17, 2024
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
raulchen
approved these changes
Jul 18, 2024
Signed-off-by: Balaji Veeramani <[email protected]>
…i/ray into improve-retry-coverage Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@raulchen @bveeramani shouldn't we also add coverage for GCP specific ERRORs? |
8 tasks
scottjlee
added a commit
that referenced
this pull request
Sep 3, 2024
## Why are these changes needed? #46685 didn't include handling for webdatasets ## Related issue number Fixes #43803 for webdatasets ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [x] I've included any doc changes needed for https://docs.ray.io/en/master/. - [x] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( --------- Signed-off-by: Eric Meier <[email protected]> Co-authored-by: Scott Lee <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 12, 2024
…6892) ## Why are these changes needed? ray-project#46685 didn't include handling for webdatasets ## Related issue number Fixes ray-project#43803 for webdatasets ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [x] I've included any doc changes needed for https://docs.ray.io/en/master/. - [x] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( --------- Signed-off-by: Eric Meier <[email protected]> Co-authored-by: Scott Lee <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…6892) ## Why are these changes needed? ray-project#46685 didn't include handling for webdatasets ## Related issue number Fixes ray-project#43803 for webdatasets ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [x] I've included any doc changes needed for https://docs.ray.io/en/master/. - [x] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( --------- Signed-off-by: Eric Meier <[email protected]> Co-authored-by: Scott Lee <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #43803 (comment).
Related issue number
Fixes #43803
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.