[test] skip dask tests on Python 3.12+ #46639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyao
approved these changes
Jul 15, 2024
rynewang
reviewed
Jul 15, 2024
rynewang
approved these changes
Jul 15, 2024
hongchaodeng
force-pushed
the
py312-skip-dasktest
branch
from
4cceaf8
to
436cc32
Compare
dask has to be upgraded to 2024.6.0 for successful builds. But on Ray side, we don't have any plan to support dask version later than 2022.10.1. So we will keep dask as is for <= Python 3.11, and skip dask tests on Python 3.12+. Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
force-pushed
the
py312-skip-dasktest
branch
from
436cc32
to
8007e9e
Compare
|
ref: #46641 |
hongchaodeng
added a commit
to hongchaodeng/ray
that referenced
this pull request
Jul 16, 2024
dask has to be upgraded to `2024.6.0` for successful builds. But on Ray side, we don't have any plan to support dask version later than `2022.10.1`. So we will keep dask as is for `<= Python 3.11`, and skip dask tests on `Python 3.12+`. Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
added a commit
to hongchaodeng/ray
that referenced
this pull request
Jul 16, 2024
dask has to be upgraded to `2024.6.0` for successful builds. But on Ray side, we don't have any plan to support dask version later than `2022.10.1`. So we will keep dask as is for `<= Python 3.11`, and skip dask tests on `Python 3.12+`. Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
added a commit
that referenced
this pull request
Jul 16, 2024
dask has to be upgraded to `2024.6.0` for successful builds. But on Ray side, we don't have any plan to support dask version later than `2022.10.1`. So we will keep dask as is for `<= Python 3.11`, and skip dask tests on `Python 3.12+`. ref: #46641 <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: hongchaodeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
dask has to be upgraded to
2024.6.0for successful builds. But on Ray side, we don't have any plan to support dask version later than2022.10.1. So we will keep dask as is for<= Python 3.11, and skip dask tests onPython 3.12+.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.