[ci] split window serve jobs into two #46595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-winserve
branch
2 times, most recently
from
f0e62d3
to
98cd0d5
Compare
aslonnie
approved these changes
Jul 12, 2024
|
maybe test it on premerge or even postmerge before merging? |
|
the buggy code path is called only on the master branch ;), but premerge will test the rest of the integration yes |
can-anyscale
force-pushed
the
can-winserve
branch
from
98cd0d5
to
3e16b61
Compare
can-anyscale
force-pushed
the
can-winserve
branch
2 times, most recently
from
eb376ac
to
c835812
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-winserve
branch
from
c835812
to
5c50875
Compare
Catch-Bull
pushed a commit
to Catch-Bull/ray
that referenced
this pull request
Jul 15, 2024
Split the window serve jobs into two - apparently the build_upload_info on windows will fail if it is called twice (https://buildkite.com/ray-project/postmerge/builds/5411#0190a59d-96ad-49a2-91d5-7572c86e4e3c/7936-7992), and this only happens on the master branch Test: - CI Signed-off-by: can <[email protected]> Signed-off-by: hejialing.hjl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the window serve jobs into two - apparently the build_upload_info on windows will fail if it is called twice (https://buildkite.com/ray-project/postmerge/builds/5411#0190a59d-96ad-49a2-91d5-7572c86e4e3c/7936-7992), and this only happens on the master branch
Test: