[core][experimental] Check whether the channel is closed for the shared memory write operation #46508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In Fix for incorrect channel read behavior after accelerated DAG teardown #46320, a check is added in
CoreWorker::Get
to avoid a mutable object being considered a normal immutable object after the channel is closed and the reader is unregistered.For the channel's
write
operation, the functionCoreWorker::ExperimentalChannelWriteAcquire
will only be called by a mutable object, and thus it doesn't have the issue of considering a mutable object as an immutable object.If we write to a channel after it is closed, an exception will be thrown as expected. However, the exception is thrown by
MutableObjectManager::WriteAcquire
, which is asymmetric with the codepath of theread
operation. For theread
operation, the exception is thrown byCoreWorker::Get
instead ofMutableObjectManager
. Hence, this PR adds a check inCoreWorker::ExperimentalChannelWriteAcquire
.ray/src/ray/core_worker/experimental_mutable_object_manager.cc
Line 234 in 6a7521c
Remove
IsChannelClosed
/ReaderChannelRegistered
/WriterChannelRegistered
because they are unused after this PR.Related issue number
#46320 (comment)
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.