Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add configuration to PhysicalOperator to allow disabling operator fusion #45949

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jun 14, 2024

Why are these changes needed?

Ray Data automatically fuses task pool operators together. However, in some cases, we want to not fuse task pool operators. To allow us to disable fusion in those cases, this PR adds a supports_fusion parameter to the physical MapOperator.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani added the go add ONLY when ready to merge, run all tests label Jun 14, 2024
@bveeramani bveeramani marked this pull request as draft June 14, 2024 01:26

def supports_fusion(self) -> bool:
"""Return ```True``` if this operator can be fused with other operators."""
return True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be False. Only map supports fusion

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani marked this pull request as ready for review June 14, 2024 18:10
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani merged commit 7449403 into ray-project:master Jun 14, 2024
6 checks passed
@bveeramani bveeramani deleted the operator-fusion branch June 15, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants