[Data] Move Parquet metadata fetching logic to separate module #45727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
raulchen
approved these changes
Jun 4, 2024
| @@ -50,22 +50,10 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| FRAGMENTS_PER_META_FETCH = 6 | |||
| PARALLELIZE_META_FETCH_THRESHOLD = 24 | |||
|
|
|||
| # The `num_cpus` for each metadata prefetching task. | |||
| # Default to 0.5 instead of 1 because it is cheaper than normal read task. | |||
| NUM_CPUS_FOR_META_FETCH_TASK = 0.5 | |||
There was a problem hiding this comment.
this one should be moved as well?
There was a problem hiding this comment.
This is used in the ParquetDatasource implementation, and not by the meta provider:
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…roject#45727) Currently, Parquet metadata fetching logic is split across parquet_datasource.py and file_meta_provider.py. Moreover, some functions defined in parquet_datasource.py are only called in file_meta_provider.py. To more coherently organize the code, this PR creates a new module parquet_meta_provider.py and moves related logic to it. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
yucai
pushed a commit
to yucai/ray
that referenced
this pull request
Jun 6, 2024
…roject#45727) Currently, Parquet metadata fetching logic is split across parquet_datasource.py and file_meta_provider.py. Moreover, some functions defined in parquet_datasource.py are only called in file_meta_provider.py. To more coherently organize the code, this PR creates a new module parquet_meta_provider.py and moves related logic to it. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: yucai <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…roject#45727) Currently, Parquet metadata fetching logic is split across parquet_datasource.py and file_meta_provider.py. Moreover, some functions defined in parquet_datasource.py are only called in file_meta_provider.py. To more coherently organize the code, this PR creates a new module parquet_meta_provider.py and moves related logic to it. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
richardsliu
pushed a commit
to richardsliu/ray
that referenced
this pull request
Jun 12, 2024
…roject#45727) Currently, Parquet metadata fetching logic is split across parquet_datasource.py and file_meta_provider.py. Moreover, some functions defined in parquet_datasource.py are only called in file_meta_provider.py. To more coherently organize the code, this PR creates a new module parquet_meta_provider.py and moves related logic to it. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Richard Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, Parquet metadata fetching logic is split across
parquet_datasource.pyandfile_meta_provider.py. Moreover, some functions defined inparquet_datasource.pyare only called infile_meta_provider.py. To more coherently organize the code, this PR creates a new moduleparquet_meta_provider.pyand moves related logic to it.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.