Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][microcheck] add a few cheap tests to microcheck #45657

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

can-anyscale
Copy link
Collaborator

Add keys to a few cheap builds and tests that I noticed failed on people's PR so we can include them in microcheck. These tests are not covered in the scope of test_in_docker.

Test:

  • CI

@@ -28,6 +28,7 @@ steps:
- forge

- label: ":tapioca: build: jar"
key: java_wheels
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does java tests actually fail or matter very much? I thought we do not really have much of java related dev activities now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed they fail in this PR here https://buildkite.com/ray-project/premerge/builds/26587; all the wheels fail actually but it's cheap enough so i add it

@can-anyscale can-anyscale enabled auto-merge (squash) May 31, 2024 17:15
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 31, 2024
@can-anyscale can-anyscale merged commit c94d8c3 into master May 31, 2024
6 of 7 checks passed
@can-anyscale can-anyscale deleted the can-mcx20 branch May 31, 2024 18:33
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
Add keys to a few cheap builds and tests that I noticed failed on
people's PR so we can include them in microcheck. These tests are not
covered in the scope of test_in_docker.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
Add keys to a few cheap builds and tests that I noticed failed on
people's PR so we can include them in microcheck. These tests are not
covered in the scope of test_in_docker.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
Add keys to a few cheap builds and tests that I noticed failed on
people's PR so we can include them in microcheck. These tests are not
covered in the scope of test_in_docker.

Test:
- CI

Signed-off-by: can <[email protected]>
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
Add keys to a few cheap builds and tests that I noticed failed on
people's PR so we can include them in microcheck. These tests are not
covered in the scope of test_in_docker.

Test:
- CI

Signed-off-by: can <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants