Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix the GIL deadlock issue caused by list_named_actors. #45582

Merged
merged 6 commits into from
May 31, 2024
Merged

[Core] Fix the GIL deadlock issue caused by list_named_actors. #45582

merged 6 commits into from
May 31, 2024

Conversation

Catch-Bull
Copy link
Contributor

@Catch-Bull Catch-Bull commented May 28, 2024 •
edited
Loading

Why are these changes needed?

This PR will fix the GIL deadlock issue caused by list_named_actors. details: #45581

Related issue number

Closes #45581

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Catch-Bull Catch-Bull requested a review from jjyao May 28, 2024 04:17
save
b679aa1 
Signed-off-by: hejialing.hjl <[email protected]>
save
33d07b5 
Signed-off-by: hejialing.hjl <[email protected]>
@Catch-Bull Catch-Bull changed the title [Core] Fix the GIL deadlock issue caused by list_named_actors. [Core] Fix the GIL deadlock issue caused by list_named_actors. May 28, 2024
hejialing.hjl added 2 commits May 28, 2024 14:57
save
fcd3ed8 
Signed-off-by: hejialing.hjl <[email protected]>
save
366d86b 
Signed-off-by: hejialing.hjl <[email protected]>
@rynewang
Copy link
Contributor

Code looks good. Will approve after CI passed. Note to myself: we need to annotate all these APIs as nogil

jjyao
jjyao approved these changes May 29, 2024
View reviewed changes
python/ray/tests/test_utils.py Outdated Show resolved Hide resolved
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels May 29, 2024
save
bac65dc 
Signed-off-by: hejialing.hjl <[email protected]>
@jjyao jjyao added go add ONLY when ready to merge, run all tests and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 29, 2024
save
9e72455 
Signed-off-by: hejialing.hjl <[email protected]>
@jjyao jjyao merged commit f9ab439 into ray-project:master May 31, 2024
6 checks passed
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@Catch-Bull @ryanaoleary
[Core] Fix the GIL deadlock issue caused by list_named_actors. (ray…
019fcc1 
…-project#45582)

Signed-off-by: hejialing.hjl <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@Catch-Bull @ryanaoleary
[Core] Fix the GIL deadlock issue caused by list_named_actors. (ray…
90b1830 
…-project#45582)

Signed-off-by: hejialing.hjl <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@Catch-Bull @ryanaoleary
[Core] Fix the GIL deadlock issue caused by list_named_actors. (ray…
37b98b8 
…-project#45582)

Signed-off-by: hejialing.hjl <[email protected]>
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
@Catch-Bull @richardsliu
[Core] Fix the GIL deadlock issue caused by list_named_actors. (ray…
9108caf 
…-project#45582)

Signed-off-by: hejialing.hjl <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

@anyscalesam anyscalesam anyscalesam left review comments

@rynewang rynewang rynewang approved these changes

Assignees

@rynewang rynewang

Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core]list_named_actors can lead to the GIL deadlock
4 participants
@Catch-Bull @rynewang @jjyao @anyscalesam