[Data] Add default parameter values for BlockAccessor.get_metadata
#45566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
raulchen
approved these changes
May 28, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ay-project#45566) BlockAccessor.get_metadata has two required arguments: input_files and exec_stats. However, we usually pass None to these arguments. To simplify the code, this PR makes the arguments optional and uses None as the default value. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ay-project#45566) BlockAccessor.get_metadata has two required arguments: input_files and exec_stats. However, we usually pass None to these arguments. To simplify the code, this PR makes the arguments optional and uses None as the default value. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…ay-project#45566) BlockAccessor.get_metadata has two required arguments: input_files and exec_stats. However, we usually pass None to these arguments. To simplify the code, this PR makes the arguments optional and uses None as the default value. Signed-off-by: Balaji Veeramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
BlockAccessor.get_metadatahas two required arguments:input_filesandexec_stats. However, we usually passNoneto these arguments. To simplify the code, this PR makes the arguments optional and usesNoneas the default value.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.