Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Remove unused _split_at_index #45481

Merged
merged 3 commits into from
May 21, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

The _split_at_index function isn't used anywhere. This PR removes it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) May 21, 2024 19:16
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 21, 2024
@github-actions github-actions bot disabled auto-merge May 21, 2024 21:05
@bveeramani bveeramani merged commit cd3d3b7 into ray-project:master May 21, 2024
6 checks passed
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
The _split_at_index function isn't used anywhere. This PR removes it.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
The _split_at_index function isn't used anywhere. This PR removes it.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
The _split_at_index function isn't used anywhere. This PR removes it.

Signed-off-by: Balaji Veeramani <[email protected]>
GabeChurch pushed a commit to GabeChurch/ray that referenced this pull request Jun 11, 2024
The _split_at_index function isn't used anywhere. This PR removes it.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: gchurch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants