[train] Setup xgboost CommunicatorContext automatically
#44883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
woshiyyya
approved these changes
Apr 22, 2024
| @@ -53,17 +51,16 @@ def train_fn_per_worker(config: dict): | |||
| "max_depth": 2, | |||
| } | |||
|
|
|||
| # 2. Do distributed data-parallel training with the `CommunicatorContext`. | |||
| # 2. Do distributed data-parallel training. | |||
| # Ray Train sets up the necessary coordinator processes and | |||
There was a problem hiding this comment.
Shall we mention CommunicatorContext here?
There was a problem hiding this comment.
I think there's no need to explain it in this example since the user shouldn't need to think about it. I could add it to the XGBoostConfig docstring since that's how users would customize the params passed into the CommunicatorContext.
| # Ray Train sets up the necessary coordinator processes and | ||
| # environment variables for your workers to communicate with each other. | ||
| with CommunicatorContext(): |
There was a problem hiding this comment.
What would happen when using a single worker for training? Will the context manager here be a noop?
There was a problem hiding this comment.
Yeah, it works with single worker
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…t#44883) Automatically set up the xgboost `CommunicatorContext` for users so they don't have to call it manually in their training code. --------- Signed-off-by: Justin Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR uses the recently added
Backend(train_func_context)configuration to automatically set up the xgboostCommunicatorContextfor users so they don't have to call it manually in their training code. Users do not need to change their single worker code as much.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.