[Serve] fix getting attributes on stdout during Serve logging redirect #44787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There are attributes on
sys.stdout
andsys.stderr
which are not implemented on ourStreamToLogger
class. When we overrided them for redirect, it will raiseAttributeError
. This caused Ray Tune unable to get the attributes on those objects on Anyscale Services where the redirect is turned on. This PR added__getattr__()
on theStreamToLogger
to get the attributes on the original object so they can still be accessible. Also added a unit test for it.Related issue number
Closes #44779
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.