Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Use signal actor to test request timeout behavior #44629

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Apr 10, 2024

Why are these changes needed?

The test was previously relying on timing to see the behavior and can be flaky. Update the test to use signal actor to ensure the chunk will be blocked until needed.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer requested a review from edoakes April 10, 2024 15:21
Signed-off-by: Gene Su <[email protected]>
@edoakes edoakes merged commit d3842f5 into ray-project:master Apr 10, 2024
5 checks passed
@GeneDer GeneDer deleted the update-request-timeout-test branch April 10, 2024 18:20
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
…t#44629)

The test was previously relying on timing to see the behavior and can be flaky. Update the test to use signal actor to ensure the chunk will be blocked until needed.

---------

Signed-off-by: Gene Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants