[train] Remove base config deepcopy when initializing the trainer actor #44611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
merge_dicts
first creates a deepcopy of the base config before doing a deep update. The deepcopy is unnecessary for this usage in Ray Train, so we can skip it and just perform a deep update.This causes issues with large objects passed into the trainer, increasing the peak memory usage of the Ray Train coordinator actor (which is labeled
_Inner
in the Ray dashboard). For example, this problem surfaced for Ray Data datasets that held a lot of metadata being passed into the trainer. (The size of the datasets is a separate issue that will be fixed.)The large objects are deep copied, which increases the memory usage of the Trainer actor by 2x. The original copy comes from the object store via
tune.with_parameters
. This copy should get garbage collected immediately after the Trainer Trainable setup is called, but for some reason the copy's memory usage sticks around for the rest of training.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.