[ci][postmerge/2] schedule gap builds #44576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6412bd0
to
b8dbc1a
Compare
5c18a9b
to
054f6f4
Compare
85ffd49
to
f9c868a
Compare
dbda268
to
3745eae
Compare
aslonnie
reviewed
Apr 12, 2024
Comment on lines
49
to
50
| f"git rev-list --reverse ^{passing_revision} {failing_revision}~", | ||
| shell=True, |
There was a problem hiding this comment.
don't use shell ? but send in the args list?
| @mock.patch( | ||
| "ci.ray_ci.pipeline.gap_filling_scheduler.GapFillingScheduler.get_gap_commits" | ||
| ) | ||
| def test_run(mock_get_gap_commits, mock_trigger_build): |
There was a problem hiding this comment.
add test case where no builds are triggered?
|
@aslonnie's comments |
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
aslonnie
reviewed
Apr 13, 2024
| .split("\n") | ||
| ) | ||
|
|
||
| def _trigger_build(self, commit: str) -> int: |
There was a problem hiding this comment.
what is the return value of this? should this return an integer as a place holder so that it respects the typing annotation?
we should probably turn on typing lints for CI python scripts..
aslonnie
approved these changes
Apr 13, 2024
Signed-off-by: can <[email protected]>
* [ci][postmerge/2] schedule gap filling builds Signed-off-by: can <[email protected]> * [ci][postmerge/2] schedule gap filling builds Signed-off-by: can <[email protected]> * [ci][postmerge/3] actually trigger build in commit gaps Signed-off-by: can <[email protected]> --------- Signed-off-by: can <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Apr 18, 2024
- Add logic to compute the list of gap commits and schedule one build for each gap - Implement the function to trigger a blocked build on postmerge - Also cache the _get_builds function which is used repeatedly and quite expensive Signed-off-by: can <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
- Add logic to compute the list of gap commits and schedule one build for each gap - Implement the function to trigger a blocked build on postmerge - Also cache the _get_builds function which is used repeatedly and quite expensive Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: