Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] [Jobs] Add more links to remote port forwarding setup #44484

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Apr 4, 2024

Why are these changes needed?

ray dashboard must be run to set up port forwarding before the Ray Dashboard can be used for REST APIs like the Ray Jobs API. This is described in a docs section, but the section isn't linked to from all the relevant places. This PR adds some links to it from the Job SDK doc, to help reduce user confusion.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni architkulkarni marked this pull request as ready for review April 4, 2024 22:54
@architkulkarni architkulkarni changed the title Add more links to remote port forwarding setup [Doc] [Jobs] Add more links to remote port forwarding setup Apr 4, 2024
Signed-off-by: Archit Kulkarni <[email protected]>
@@ -246,4 +247,4 @@ The ``verify`` parameter can be set to override this behavior. For example:
client = JobSubmissionClient("https://<job-server-url>", verify="/path/to/cert.pem")

will use the certificate found at ``/path/to/cert.pem`` to verify the job server's certificate.
Certificate verification can be disabled by setting the ``verify`` parameter to ``False``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between the deleted line and the new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea... Maybe the linter did it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or a github bug

@architkulkarni architkulkarni merged commit 2079472 into master Apr 5, 2024
4 of 5 checks passed
@architkulkarni architkulkarni deleted the job-port-forward-links-doc branch April 5, 2024 15:16
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
…ect#44484)

ray dashboard must be run to set up port forwarding before the Ray Dashboard can be used for REST APIs like the Ray Jobs API. This is described in a docs section, but the section isn't linked to from all the relevant places. This PR adds some links to it from the Job SDK doc, to help reduce user confusion.

---------

Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants