Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix the config to disable progress bar #44342

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

c21
Copy link
Contributor

@c21 c21 commented Mar 28, 2024

Why are these changes needed?

This is a followup of #43360 to fix the behavior of disabling progress bar. After this PR, users only need to set ray.data.DataContext.get_current().enable_progress_bars = False to disable all progress bar (main + verbose bar per operator).

Tested locally and verified config is working.

Related issue number

Closes #44267

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

c21 added 2 commits April 15, 2024 15:51
Signed-off-by: Cheng Su <[email protected]>
@c21 c21 merged commit a130313 into ray-project:master Apr 17, 2024
5 checks passed
@c21 c21 deleted the fix-bar branch April 17, 2024 04:38
harborn pushed a commit to harborn/ray that referenced this pull request Apr 18, 2024
This is a followup of ray-project#43360 to fix the behavior of disabling progress bar. After this PR, users only need to set `ray.data.DataContext.get_current().enable_progress_bars = False` to disable all progress bar (main + verbose bar per operator).

Tested locally and verified config is working. 

Signed-off-by: Cheng Su <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
This is a followup of ray-project#43360 to fix the behavior of disabling progress bar. After this PR, users only need to set `ray.data.DataContext.get_current().enable_progress_bars = False` to disable all progress bar (main + verbose bar per operator).

Tested locally and verified config is working. 

Signed-off-by: Cheng Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] RAY_DATA_DISABLE_PROGRESS_BARS doesn't disable all progress bars
3 participants