[ci] fix a few tests on macosx #44200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: can <[email protected]>
aslonnie
approved these changes
Mar 21, 2024
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Mar 27, 2024
Fix the 'core and dashboard tests', they are currently fail to build these two tests: https://buildkite.com/ray-project/postmerge-macos/builds/210#018e5df5-b706-4629-96e4-b0612621d205/3815-5824 One of the test the path to the test file is incorrect (however it's symlink version runs fine https://buildkite.com/ray-project/postmerge-macos/builds/210#018e5df5-b706-4629-96e4-b0612621d205/3815-5952) The other one should not be run on macos Signed-off-by: can <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Fix the 'core and dashboard tests', they are currently fail to build these two tests: https://buildkite.com/ray-project/postmerge-macos/builds/210#018e5df5-b706-4629-96e4-b0612621d205/3815-5824 One of the test the path to the test file is incorrect (however it's symlink version runs fine https://buildkite.com/ray-project/postmerge-macos/builds/210#018e5df5-b706-4629-96e4-b0612621d205/3815-5952) The other one should not be run on macos Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the 'core and dashboard tests', they are currently fail to build these two tests: https://buildkite.com/ray-project/postmerge-macos/builds/210#018e5df5-b706-4629-96e4-b0612621d205/3815-5824
One of the test the path to the test file is incorrect (however it's symlink version runs fine https://buildkite.com/ray-project/postmerge-macos/builds/210#018e5df5-b706-4629-96e4-b0612621d205/3815-5952)
The other one should not be run on macos
Test: