[cluster launcher] skip cleanup security groups on non-aws tests #44102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
requested review from
ericl,
architkulkarni and
a team
as code owners
hongchaodeng
force-pushed
the
fix-releasetest
branch
from
5782aac
to
6732e83
Compare
Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
force-pushed
the
fix-releasetest
branch
from
6732e83
to
50dd580
Compare
|
I cloned a workspace in release test and verified the following test succeeded: |
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Mar 27, 2024
…-project#44102) We only need to cleanup security groups for cluster launcher tests on AWS environments. Skip it on others. Related issue number Closes ray-project#44034 Signed-off-by: hongchaodeng <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…-project#44102) We only need to cleanup security groups for cluster launcher tests on AWS environments. Skip it on others. Related issue number Closes ray-project#44034 Signed-off-by: hongchaodeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We only need to cleanup security groups for cluster launcher tests on AWS environments. Skip it on others.
Related issue number
Closes #44034
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.