Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Job] ray job subcommand is missing in command line help message #44071

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[Job] ray job subcommand is missing in command line help message #44071

merged 1 commit into from
Mar 19, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Mar 17, 2024 •
edited
Loading

Why are these changes needed?

  • "hidden (bool) – hide this command from help outputs." (ref)

Related issue number

Closes #42391

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
Screen Shot 2024-03-17 at 6 11 13 AM

@kevin85421
update
9906bda 
Signed-off-by: kaihsun <[email protected]>
@kevin85421 kevin85421 mentioned this pull request Mar 17, 2024
Closed
@kevin85421 kevin85421 requested a review from jjyao March 17, 2024 13:19
@kevin85421 kevin85421 requested a review from GeneDer March 17, 2024 13:20
GeneDer
GeneDer approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kai-Hsun!

@jjyao jjyao merged commit 1c41173 into ray-project:master Mar 19, 2024
5 checks passed
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Mar 27, 2024
@kevin85421 @stephanie-wang
[Job] ray job subcommand is missing in command line help message (ray…
3065779 
…-project#44071)

Signed-off-by: kaihsun <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@kevin85421 @ryanaoleary
[Job] ray job subcommand is missing in command line help message (ray…
efbec16 
…-project#44071)

Signed-off-by: kaihsun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

@jjyao jjyao Awaiting requested review from jjyao

Assignees

@jjyao jjyao

@GeneDer GeneDer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ray job subcommand is missing in command line help message
3 participants
@kevin85421 @GeneDer @jjyao