[Core] Deflaky memory_monitor_test #44039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemoryMonitorTest::TestMonitorMinFreeZeroThresholdIsOne was failing because two floats were directly compared for equality rather than equality within a delta. I printed out the hex representation for both floats and saw the following: 0.4f has a hex representation of 0x1.99999ap-2 usage_threshold has a hex representation of 0x1.99999cp-2 Thus, the two floats are different. I replaced ASSERT_EQ() with ASSERT_FLOAT_EQ() and the test now passes. I also replaced a couple other instances of checking for float equality using ASSERT_EQ() with ASSERT_FLOAT_EQ(). Tested: bazel test src/ray/common/test:memory_monitor_test Signed-off-by: Jack Humphries <[email protected]>
jjyao
approved these changes
Mar 23, 2024
jackhumphries
added a commit
to jackhumphries/ray
that referenced
this pull request
Mar 23, 2024
Signed-off-by: Jack Humphries <[email protected]>
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Jack Humphries <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Jack Humphries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryMonitorTest::TestMonitorMinFreeZeroThresholdIsOnewas failing because two floats were directly compared for equality rather than equality within a delta. I printed out the hex representation for both floats and saw the following:0.4fhas a hex representation of0x1.99999ap-2usage_thresholdhas a hex representation of0x1.99999cp-2Thus, the two floats are different.
I replaced
ASSERT_EQ()withASSERT_FLOAT_EQ()and the test now passes. There were also a couple other instances of checking for float equality that I updated to useASSERT_FLOAT_EQ().Tested:
bazel test src/ray/common/test:memory_monitor_testWhy are these changes needed?
Fix for issue #44027
Related issue number
Close #44027
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.