[KubeRay] [Doc] [Clusters] Fix RayCluster quickstart and VM quickstart for mac #43781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <[email protected]>
…thostname() Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
|
Doc tabs look correct. (it's purple in the second one because my mouse was hovering on it) 
|
kevin85421
approved these changes
Mar 7, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…t for mac (ray-project#43781) * Update RayCluster deployment instructions for ARM64 and x86-64 Signed-off-by: Archit Kulkarni <[email protected]> * Update socket.gethostbyname() to use 'localhost' instead of socket.gethostname() Signed-off-by: Archit Kulkarni <[email protected]> * Lint Signed-off-by: Archit Kulkarni <[email protected]> * Lint Signed-off-by: Archit Kulkarni <[email protected]> --------- Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KubeRay RayCluster quickstart didn't work out of the box for Apple silicon macs (M1, M2, etc). This PR fixes it by adding an alternative instruction to use the
-aarch64image.The code snippet
socket.gethostbyname(socket.gethostname())in the VM cluster quickstart didn't work for newer Mac OS versions; see the linked issue for full details. This PR fixes the issue by usingsocket.gethostbyname("localhost")instead.Thanks to @darktempla for diagnosing the issue and providing the fix!
Why are these changes needed?
Related issue number
Closes #42964
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.