[Serve] fix test_logging failing on python 3.11 #43780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <[email protected]>
… are correct Signed-off-by: Gene Su <[email protected]>
|
test_logging on python 3.11 now passing https://buildkite.com/ray-project/postmerge/builds/3357#018e1b0e-e563-44d1-8762-bf3a1fc29d9e/191-1776 |
Signed-off-by: Gene Su <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
There is a breaking change in Python 3.11 with string enum getting interpolated to "ServeComponentType.REPLICA" rather than the underlaying value of "replica". Fixes the file name and added a test to ensure serve's log files have correct naming. --------- Signed-off-by: Gene Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There is a breaking change in Python 3.11 with string enum getting interpolated to "ServeComponentType.REPLICA" rather than the underlaying value of "replica". Fixes the file name and added a test to ensure serve's log files have correct naming.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.