[serve] Disable task events by default for Serve actors #43613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
|
Still need to add a test |
jjyao
approved these changes
Mar 1, 2024
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
…e-disable-task-events
Signed-off-by: Edward Oakes <[email protected]>
hebiao064
pushed a commit
to hebiao064/ray
that referenced
this pull request
Mar 12, 2024
…43613) Disables task events by default because they aren't useful and add "junk traffic" to the cluster. Adds a feature flag to re-enable as an escape hatch. --------- Signed-off-by: Edward Oakes <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…43613) Disables task events by default because they aren't useful and add "junk traffic" to the cluster. Adds a feature flag to re-enable as an escape hatch. --------- Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Disables task events by default because they aren't useful and add "junk traffic" to the cluster.
Adds a feature flag to re-enable as an escape hatch.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.