[CI] [Lint] [Dashboard] Make frontend linter automatically fix lint issues #43515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues When making dashboard frontend changes, the linter outputs things like ` 0 errors and 7 warnings potentially fixable with the `--fix` option.` This PR adds the `--fix` command to the linter script to automatically fix lint issues when possible. This is consistent with how the other linters work in the script for non-frontend code. Signed-off-by: Archit Kulkarni <[email protected]>
architkulkarni
requested review from
richardliaw,
ericl and
edoakes
as code owners
edoakes
approved these changes
Feb 28, 2024
hongchaodeng
pushed a commit
to hongchaodeng/ray
that referenced
this pull request
Mar 13, 2024
…ssues (ray-project#43515) When making dashboard frontend changes, the linter outputs things like ` 0 errors and 7 warnings potentially fixable with the `--fix` option.` This PR adds the `--fix` command to the linter script to automatically fix lint issues when possible. This is consistent with how the other linters work in the script for non-frontend code. Signed-off-by: Archit Kulkarni <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…ssues (ray-project#43515) When making dashboard frontend changes, the linter outputs things like ` 0 errors and 7 warnings potentially fixable with the `--fix` option.` This PR adds the `--fix` command to the linter script to automatically fix lint issues when possible. This is consistent with how the other linters work in the script for non-frontend code. Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making dashboard frontend changes, the linter outputs things like
0 errors and 7 warnings potentially fixable with the--fixoption.This PR adds the
--fixcommand to the linter script to automatically fix lint issues when possible. This is consistent with how the other linters work in the script for non-frontend code.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.