[Data] Fix logging of set_read_parallelism rule #43423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
raulchen
approved these changes
Feb 26, 2024
bveeramani
approved these changes
Feb 26, 2024
| @@ -43,18 +43,18 @@ def compute_additional_split_factor( | |||
|
|
|||
| available_cpu_slots = ray_available_resources().get("CPU", 1) | |||
| if ( | |||
| parallelism | |||
| parallelism > 0 | |||
There was a problem hiding this comment.
Nit: might be easier to understand as "user-specified parallelism"
Suggested change
| parallelism > 0 | |
| parallelism != -1 |
Signed-off-by: Cheng Su <[email protected]>
Signed-off-by: Cheng Su <[email protected]>
c21
force-pushed
the
cleanup-parallelism
branch
from
da06394
to
a2a2031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is to fix the logging of set_read_parallelism rule. Avoid printing the warning for parallelism being set to high, when user does not set parallelism manually. Also, rewording the warning to avoid mentioning parallelism.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.