Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Avoid warning of compute argument in add/select/drop_columns() #43392

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

c21
Copy link
Contributor

@c21 c21 commented Feb 23, 2024

Why are these changes needed?

This PR is to fix the bug when user uses add/select/drop_columns without compute/concurrency API. Before this PR, it prints out a deprecation warning by mistake. This PR is to avoid printing out the warning.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@@ -646,12 +646,6 @@ def add_column(
ray_remote_args: Additional resource requirements to request from
ray (e.g., num_gpus=1 to request GPUs for the map tasks).
"""
compute = get_compute_strategy(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map_batches calls get_compute_strategy inside it. So we don't need to call get_compute_strategy here.

Signed-off-by: Cheng Su <[email protected]>
@c21 c21 merged commit 852564c into ray-project:master Feb 23, 2024
8 of 9 checks passed
@c21 c21 deleted the fix-concurrency branch February 23, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants