Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib, Tune, AIR] Support of images and video logging in wandb. #43356

Merged

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Feb 22, 2024

Why are these changes needed?

We support image and video loggign in TensorboardX, but not in wandb. This PR wants to close this gap and proposes a way to log images and videos in wandb, too.

Related issue number

Closes #38157

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 marked this pull request as ready for review April 17, 2024 15:22
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sven1977 sven1977 changed the title Support of images and video logging in wandb. [RLlib, Tune, AIR] Support of images and video logging in wandb. Apr 17, 2024
@sven1977 sven1977 merged commit dcc3847 into ray-project:master Apr 17, 2024
9 checks passed
@sven1977 sven1977 self-assigned this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Air|Tune] Allow Image logging in WandB
2 participants