[Serve] Make serialized_policy_def and policy private
#43291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <[email protected]>
serialized_policy_def and policy private
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
This reverts commit 5b04b2f. Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
a9384b9
to
3648b2c
Compare
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
GeneDer
commented
Feb 22, 2024
| @@ -92,13 +93,18 @@ def replicas_settings_valid(cls, max_replicas, values): | |||
|
|
|||
| return max_replicas | |||
|
|
|||
| @validator("policy", always=True) | |||
There was a problem hiding this comment.
Validator is unable to run for attributes starting with underscore. So overriding init to call serialize_policy after init
edoakes
approved these changes
Feb 22, 2024
|
|
||
| # Custom autoscaling config. Defaults to the request-based autoscaler. | ||
| policy: Union[str, Callable] = DEFAULT_AUTOSCALING_POLICY | ||
| _policy: Union[str, Callable] = PrivateAttr(default=DEFAULT_AUTOSCALING_POLICY) |
There was a problem hiding this comment.
this doesn't show up in the API reference because it's underscore prefixed right?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make
serialized_policy_defandpolicyprivate so users know not to use them.Related issue number
Closes: #43292
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.