Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][train] Remove unnecessary xgboost_ray/lightgbm_ray reinstalls for release tests #43176

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Feb 14, 2024

Why are these changes needed?

#42111 removed classes that were depended on by the latest release of xgboost_ray. The master branch of this external library has some changes that remove this dependency, which was updated in ml/core-requirements.txt.

However, post build scripts for release tests install the latest version of these libraries, causing all these release test failures. We should test with the master version of the external libraries. This is a temporary measure, since we are planning to remove xgboost_ray and lightgbm_ray dependencies from Ray for 2.10 (to finish within 2 weeks).

Related issue number

Closes #43155
Closes #43161
Closes #43163
Closes #43156
Closes #43157
Closes #43158
Closes #43159

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@justinvyu justinvyu requested a review from a team as a code owner February 14, 2024 20:27
@justinvyu justinvyu changed the title remove unnecessary xgboost_ray/lightgbm_ray reinstall [ci][train] Remove unnecessary xgboost_ray/lightgbm_ray reinstalls for release tests Feb 14, 2024
@justinvyu
Copy link
Contributor Author

@aslonnie Addressed your comment. Could I get another review / approval? This is to fix broken release tests.

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also works.

I thought you wanted to update the deps in ml/core-requirements

@justinvyu
Copy link
Contributor Author

ml/core-requirements is not included in these release tests for some reason. See my attempt here: https://buildkite.com/ray-project/release/builds/8456#018da94d-2df2-4022-a383-63293e561427

I'm not going to spend time to figure it out since I am trying to remove this dependency within a week.

@justinvyu justinvyu merged commit 71d37ff into ray-project:master Feb 16, 2024
9 checks passed
@justinvyu justinvyu deleted the xgboost_release_tests branch February 16, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants