Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add concurrency and deprecate parallelism for all read APIs #43113

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

c21
Copy link
Contributor

@c21 c21 commented Feb 12, 2024

Why are these changes needed?

This PR is to add concurrency and deprecate parallelism w/ override_num_blocks for all read APIs.

In addition, adding a unit test for read_parquet for concurrency.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

python/ray/data/read_api.py Outdated Show resolved Hide resolved
python/ray/data/read_api.py Show resolved Hide resolved
python/ray/data/read_api.py Outdated Show resolved Hide resolved
python/ray/data/read_api.py Outdated Show resolved Hide resolved
python/ray/data/read_api.py Outdated Show resolved Hide resolved
python/ray/data/read_api.py Show resolved Hide resolved
python/ray/data/read_api.py Outdated Show resolved Hide resolved
python/ray/data/read_api.py Outdated Show resolved Hide resolved
Signed-off-by: Cheng Su <[email protected]>
@c21 c21 merged commit e973f2e into ray-project:master Feb 14, 2024
9 checks passed
@c21 c21 deleted the read-other branch February 14, 2024 00:26
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 17, 2024
…ay-project#43113)

This PR is to add concurrency and deprecate parallelism w/ override_num_blocks for all read APIs.

In addition, adding a unit test for read_parquet for concurrency.

Signed-off-by: Cheng Su <[email protected]>
c21 added a commit that referenced this pull request Mar 5, 2024
…43692)

This PR is to remove Ray Data read `parallelism`, replace with `override_num_blocks` from all libraries and unit tests. The PR change on Ray Data is #43113 .

Signed-off-by: Cheng Su <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
…ay-project#43692)

This PR is to remove Ray Data read `parallelism`, replace with `override_num_blocks` from all libraries and unit tests. The PR change on Ray Data is ray-project#43113 .

Signed-off-by: Cheng Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants