Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add C++ unit test for experimental shared memory channels #42923

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

stephanie-wang
Copy link
Contributor

Why are these changes needed?

Add C++ unit tests to cover basic scenarios:

  • single writer, single reader
  • single writer, multiple reader
  • writer fails
  • reader fails

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Stephanie Wang <[email protected]>
@stephanie-wang stephanie-wang merged commit b86e4ef into ray-project:master Feb 13, 2024
9 checks passed
@stephanie-wang stephanie-wang deleted the channel-cpp-unit branch February 13, 2024 18:32
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 17, 2024
…-project#42923)

Add C++ unit tests to cover basic scenarios:

    single writer, single reader
    single writer, multiple reader
    writer fails
    reader fails

---------

Signed-off-by: Stephanie Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants