Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Skip schema call in to_tf if tf.TypeSpec is provided #42917

Merged
merged 5 commits into from
Feb 8, 2024
Merged

[Data] Skip schema call in to_tf if tf.TypeSpec is provided #42917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0367a26
Auto-infer tf.TypeSpec of columns in
c21 Feb 1, 2024
1dcf4d8
Fix type
c21 Feb 1, 2024
c5db033
Change to call if type_spec not provided
c21 Feb 2, 2024
1992bc1
Add unit test
c21 Feb 7, 2024
cad3d4f
Fix test
c21 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type 
Signed-off-by: Cheng Su <[email protected]>
  • Loading branch information
@c21
c21 committed Feb 7, 2024
commit 1dcf4d8750f2abea440a552b5b6b733a2698698f
4 changes: 2 additions & 2 deletions python/ray/data/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4004,8 +4004,8 @@ def to_tf(
drop_last: bool = False,
local_shuffle_buffer_size: Optional[int] = None,
local_shuffle_seed: Optional[int] = None,
feature_type_spec: Union[tf.TypeSpec, Dict[str, tf.TypeSpec]] = None,
label_type_spec: Union[tf.TypeSpec, Dict[str, tf.TypeSpec]] = None,
feature_type_spec: Union["tf.TypeSpec", Dict[str, "tf.TypeSpec"]] = None,
label_type_spec: Union["tf.TypeSpec", Dict[str, "tf.TypeSpec"]] = None,
# Deprecated
prefetch_blocks: int = 0,
) -> "tf.data.Dataset":
Expand Down
4 changes: 2 additions & 2 deletions python/ray/data/iterator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,8 @@ def to_tf(
drop_last: bool = False,
local_shuffle_buffer_size: Optional[int] = None,
local_shuffle_seed: Optional[int] = None,
feature_type_spec: Union[tf.TypeSpec, Dict[str, tf.TypeSpec]] = None,
label_type_spec: Union[tf.TypeSpec, Dict[str, tf.TypeSpec]] = None,
feature_type_spec: Union["tf.TypeSpec", Dict[str, "tf.TypeSpec"]] = None,
label_type_spec: Union["tf.TypeSpec", Dict[str, "tf.TypeSpec"]] = None,
# Deprecated.
prefetch_blocks: int = 0,
) -> "tf.data.Dataset":
Expand Down