[Data] Add concurrency and deprecate parallelism for read_parquet APIs #42849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
Zandew
as code owners
bveeramani
reviewed
Jan 31, 2024
Comment on lines
+185
to
+187
| ds = ray.data.read_parquet(data_path, filesystem=fs, concurrency=1) | ||
| values = [s["one"] for s in ds.take()] | ||
| assert sorted(values) == [1, 2, 3, 4, 5, 6] |
There was a problem hiding this comment.
read_parquet could launch more than one concurrent read task and this assertion would still pass. Is there any easy way to test that the concurrency is enforced?
There was a problem hiding this comment.
Yes, planning to add some test similar to est_backpressure_policies.py:test_basic. But good callout.
raulchen
reviewed
Feb 1, 2024
raulchen
approved these changes
Feb 1, 2024
Signed-off-by: Cheng Su <[email protected]>
Signed-off-by: Cheng Su <[email protected]>
c21
changed the title
raulchen
approved these changes
Feb 7, 2024
Signed-off-by: Cheng Su <[email protected]>
|
Just realized that we also need to update unit tests that use |
Yes, those are okay and won't be broken. We can change in another PR. |
ratnopamc
pushed a commit
to ratnopamc/ray
that referenced
this pull request
Feb 11, 2024
ray-project#42849) This PR is to add a new `concurrency` parameter for read APIs. The motivation is to allow users to control concurrency for read operator as well, other than map operators. TODO: Add `concurrency` parameter for all read APIs besides `read_parquet` once we agree on the change. Otherwise too many documentation change needs to make. Signed-off-by: Cheng Su <[email protected]> Signed-off-by: Ratnopam Chakrabarti <[email protected]>
tterrysun
pushed a commit
to tterrysun/ray
that referenced
this pull request
Feb 14, 2024
ray-project#42849) This PR is to add a new `concurrency` parameter for read APIs. The motivation is to allow users to control concurrency for read operator as well, other than map operators. TODO: Add `concurrency` parameter for all read APIs besides `read_parquet` once we agree on the change. Otherwise too many documentation change needs to make. Signed-off-by: Cheng Su <[email protected]> Signed-off-by: tterrysun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is to add a new
concurrencyparameter for read APIs. The motivation is to allow users to control concurrency for read operator as well, other than map operators.TODO: Add
concurrencyparameter for all read APIs besidesread_parquetonce we agree on the change. Otherwise too many documentation change needs to make.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.