Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make microbenchmark stable again #42813

Merged

Conversation

stephanie-wang
Copy link
Contributor

Why are these changes needed?

Move all experimental code to a separate microbenchmark file to avoid any interference.

Related issue number

Closes #42602.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Stephanie Wang <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
@aslonnie
Copy link
Collaborator

ready to merge?

@stephanie-wang stephanie-wang merged commit 851d154 into ray-project:master Feb 1, 2024
9 checks passed
@stephanie-wang stephanie-wang deleted the microbenchmark-unstable branch February 1, 2024 00:05
shrekris-anyscale pushed a commit to shrekris-anyscale/ray that referenced this pull request Feb 1, 2024
Move all experimental code to a separate microbenchmark file to avoid any interference.
Related issue number

Closes ray-project#42602.

---------

Signed-off-by: Stephanie Wang <[email protected]>
tterrysun pushed a commit to tterrysun/ray that referenced this pull request Feb 14, 2024
Move all experimental code to a separate microbenchmark file to avoid any interference.
Related issue number

Closes ray-project#42602.

---------

Signed-off-by: Stephanie Wang <[email protected]>
Signed-off-by: tterrysun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release test microbenchmark_unstable failed
4 participants