[ci] Re-enable Windows test on premerge #42726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
439e202
to
79c47df
Compare
aslonnie
reviewed
Jan 26, 2024
.buildkite/core.rayci.yml
Outdated
| @@ -71,7 +71,7 @@ steps: | |||
| --except-tags debug_tests,asan_tests,post_wheel_build,ha_integration,mem_pressure,tmpfs,container,manual | |||
|
|
|||
| - label: ":ray: core: :windows: python tests" | |||
| if: build.env("RAYCI_CONTINUOUS_BUILD") == "1" || build.pull_request.labels includes "continuous-build" | |||
| if: build.env("BUILDKITE_PIPELINE_ID") == "0189942e-0876-4b8f-80a4-617f988ec59b" || build.env("RAYCI_CONTINUOUS_BUILD") == "1" || build.pull_request.labels includes "continuous-build" | |||
There was a problem hiding this comment.
remove || build.pull_request.labels includes "continuous-build" ? if it is a PR, it now runs on premerge and will always run?
aslonnie
approved these changes
Jan 26, 2024
Signed-off-by: khluu <[email protected]>
aslonnie
reviewed
Jan 26, 2024
.buildkite/core.rayci.yml
Outdated
| @@ -71,7 +71,7 @@ steps: | |||
| --except-tags debug_tests,asan_tests,post_wheel_build,ha_integration,mem_pressure,tmpfs,container,manual | |||
|
|
|||
| - label: ":ray: core: :windows: python tests" | |||
| if: build.env("BUILDKITE_PIPELINE_ID") == "0189942e-0876-4b8f-80a4-617f988ec59b" || build.env("RAYCI_CONTINUOUS_BUILD") == "1" || build.pull_request.labels includes "continuous-build" | |||
| if: build.env("BUILDKITE_PIPELINE_ID") == "0189942e-0876-4b8f-80a4-617f988ec59b" || build.env("RAYCI_CONTINUOUS_BUILD") == "1" | |||
There was a problem hiding this comment.
rather than using build.env("BUILDKITE_PIPELINE_ID"), just use pipeline.id ?
There was a problem hiding this comment.
see https://buildkite.com/docs/pipelines/conditionals#variable-and-syntax-reference-variables for supported builtin variables.
There was a problem hiding this comment.
Thank you! I've updated them all to use pipeline.id. Will merge the PR after the tests run.
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
khluu
added a commit
that referenced
this pull request
Jan 27, 2024
These tests were added a condition to only run when there's the continuous build flag on, which also disables it on premerge. Signed-off-by: khluu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Changes
premerge.Checks