[Data] Add section on diagnosing reduced throughput with local shuffle buffer #42615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
raulchen
approved these changes
Jan 23, 2024
| examining the ``ds.stats()`` output (``In batch formatting`` under | ||
| ``Batch iteration time breakdown``). If this time is significantly larger than the | ||
| time spent in other steps, one way to improve performance is to decrease | ||
| ``local_shuffle_buffer_size`` or turn off the local shuffle buffer altogether. |
There was a problem hiding this comment.
maybe also mention the input file shuffle method as a cheaper alternative?
Signed-off-by: Scott Lee <[email protected]>
|
Do you think you could merge the message with the previous tip? Seems there's some overlap in the content about local shuffling vs file shuffling. |
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
stephanie-wang
approved these changes
Jan 24, 2024
Co-authored-by: Stephanie Wang <[email protected]> Signed-off-by: Scott Lee <[email protected]>
stephanie-wang
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add a section describing how to diagnose reduced throughput when iterating over a Ray Dataset with local shuffle buffer enabled.
Transforming Data
Iterating over Data
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.