Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Increase timeout on test_status_package_unavailable_in_controller #42495

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[serve] Increase timeout on test_status_package_unavailable_in_controller #42495

merged 1 commit into from
Jan 18, 2024

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jan 18, 2024

Why are these changes needed?

This test installs some pip packages in a runtime env. This can sometimes take longer than 15s.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
fix
93d4624 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes requested a review from a team January 18, 2024 20:28
@edoakes
Copy link
Contributor Author

edoakes commented Jan 18, 2024 •
edited
Loading

Has been timing out recently:

GeneDer
GeneDer approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edoakes edoakes merged commit 06438b1 into ray-project:master Jan 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

@aslonnie aslonnie aslonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edoakes @GeneDer @aslonnie