Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Fix and unblock Serve flaky tests #42429

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Jan 16, 2024

Why are these changes needed?

Re: #42682 Startlette and fastapi issue have been fixed. Unblock Serve flaky tests.

Related issue number

Closes

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer changed the title [Serve] pin Starlette to 0.34.0 [Serve] Fix and unblock Serve flaky tests Jan 26, 2024
@GeneDer GeneDer marked this pull request as ready for review January 29, 2024 18:18
@GeneDer
Copy link
Contributor Author

GeneDer commented Jan 29, 2024

Also ran postmerge and seeing all serve tests passing https://buildkite.com/ray-project/postmerge/builds/2735#_

Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@edoakes edoakes merged commit 87cd741 into ray-project:master Jan 29, 2024
9 checks passed
@GeneDer GeneDer deleted the fix-flaky-test-api branch January 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants