Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Make GPU name tooltip appear when hovering over entire GPU entry #42283

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Jan 9, 2024

Why are these changes needed?

Previously the GPU name would only appear when hovering over the slot name (the part that says [0]).

This PR makes it appear also when hovering over the rest of the entry (the utilization bar). This is consistent with how the GRAM entry is currently displayed.

Related issue number

Closes #42208

Context copied from the linked issue:

Actually, for the GPU column, the tooltip currently appears, but only if you hover over the "[0]" part, not over the utilization bar.

Screenshot 2024-01-09 at 3 23 46 PM

For the GRAM column, the tooltip appears if you hover over the "[0]" part or the utilization bar.
Screenshot 2024-01-09 at 3 24 26 PM

So I think we just need to make sure that the tooltip appears when hovering over the utilization bar in the GPU column.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Archit Kulkarni <[email protected]>
@architkulkarni
Copy link
Contributor Author

@alanwguo how would you recommend testing this part (manually or otherwise)?

@alanwguo
Copy link
Contributor

alanwguo commented Jan 9, 2024

@alanwguo how would you recommend testing this part (manually or otherwise)?

One way is to let this PR build a ray wheel and install it as a cluster env to use on Anyscale and launch a machine with a GPU.

Alternatively, you can test with a kube-ray cluster with a GPU node?

@architkulkarni
Copy link
Contributor Author

It works:

Uploading Screen Recording 2024-01-11 at 11.32.29 AM.mov…

@architkulkarni
Copy link
Contributor Author

Screenshot 2024-01-11 at 11 38 49 AM
Screen.Recording.2024-01-11.at.11.32.29.AM.mov

Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@architkulkarni architkulkarni merged commit b20a517 into ray-project:master Jan 11, 2024
9 checks passed
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
…U entry (ray-project#42283)

* Make tooltip appear over entire GPU entry instead of just the slot number (e.g. [0])

Signed-off-by: Archit Kulkarni <[email protected]>

* Lint

Signed-off-by: Archit Kulkarni <[email protected]>

---------

Signed-off-by: Archit Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ray Dashboard: Better GPU utilization visibility
2 participants