Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profile manager] add verbose option #42160

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Jan 3, 2024

and prints profiler output on test failure

@can-anyscale
Copy link
Collaborator

Look like test failed, is that expected?

and prints profiler output on test failure

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie
Copy link
Collaborator Author

aslonnie commented Jan 3, 2024

Look like test failed, is that expected?

nope. trying to fix it now.

@aslonnie
Copy link
Collaborator Author

aslonnie commented Jan 3, 2024

should be fixed. please take another look

@aslonnie
Copy link
Collaborator Author

aslonnie commented Jan 3, 2024

@jonathan-anyscale is attach_profile() part of ray public API? is it okay to add the verbose arg?

Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aslonnie aslonnie requested review from rickyyx and alanwguo and removed request for jonathan-anyscale January 3, 2024 21:55
@aslonnie
Copy link
Collaborator Author

aslonnie commented Jan 3, 2024

seems that Jonathan is an intern and has already left the project

@aslonnie aslonnie assigned rickyyx and unassigned jonathan-anyscale Jan 3, 2024
@rickyyx rickyyx merged commit 46aac4d into master Jan 3, 2024
9 checks passed
@rickyyx rickyyx deleted the lonnie-0103-memrayverb branch January 3, 2024 22:37
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
and prints profiler output on test failure

Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants