Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc model_composition.md Basic Deployment line number Example #42108

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix: doc model_composition.md Basic Deployment line number Example #42108

merged 2 commits into from
Dec 28, 2023

Conversation

klebster2
Copy link
Contributor

@klebster2 klebster2 commented Dec 27, 2023

Update line numbers (some of the line numbers were inaccurate).

Why are these changes needed?

Fixing an inaccurate line number references in an example found in the docs (specifically, the serve documentation).

This is to increase readability for those interested in the docs. Here is the problematic doc: Basic Deployment Example.

Related issue number

None known

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Update line numbers

Signed-off-by: Kleber Noel <[email protected]>
@klebster2 klebster2 marked this pull request as draft December 27, 2023 19:38
@klebster2 klebster2 marked this pull request as ready for review December 27, 2023 19:38
@edoakes
Copy link
Contributor

edoakes commented Dec 28, 2023

Thanks!

@edoakes edoakes merged commit 33f1a6f into ray-project:master Dec 28, 2023
9 checks passed
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
Update line numbers

Signed-off-by: Kleber Noel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants